Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: message withdraw emissions #1825

Merged
merged 29 commits into from
Mar 5, 2024
Merged

feat: message withdraw emissions #1825

merged 29 commits into from
Mar 5, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Mar 1, 2024 •
edited
Loading

Description

Add a message to enable observers to collect emission rewards
Closes: #1653

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD changed the title feate : message withdraw emissions feat : message withdraw emissions Mar 1, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 33.95%. Comparing base (422e00e) to head (f35ffd7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1825      +/-   ##
===========================================
+ Coverage    33.36%   33.95%   +0.59%     
===========================================
  Files          130      132       +2     
  Lines         9205     9253      +48     
===========================================
+ Hits          3071     3142      +71     
+ Misses        5909     5886      -23     
  Partials       225      225
Files Coverage Δ
.../emissions/keeper/msg_server_withdraw_emissions.go 100.00% <100.00%> (ø)
x/emissions/keeper/withdrawable_emissions.go 100.00% <100.00%> (+100.00%) ⬆️
x/emissions/types/message_withdraw_emissions.go 42.85% <42.85%> (ø)

@kingpinXD kingpinXD changed the title feat : message withdraw emissions feat: message withdraw emissions Mar 2, 2024
lumtis
lumtis reviewed Mar 4, 2024
View reviewed changes
testutil/keeper/keeper.go Outdated Show resolved Hide resolved
x/emissions/client/cli/tx_create_withdraw_emssions.go Outdated Show resolved Hide resolved
x/emissions/types/errors.go Outdated Show resolved Hide resolved
x/emissions/types/message_withdraw_emissions.go Outdated Show resolved Hide resolved
x/emissions/types/message_withdraw_emissions.go Outdated Show resolved Hide resolved
x/emissions/keeper/msg_server_withdraw_emissions.go Outdated Show resolved Hide resolved
x/emissions/keeper/msg_server_withdraw_emissions.go Outdated Show resolved Hide resolved
x/emissions/keeper/msg_server_withdraw_emissions.go Outdated Show resolved Hide resolved
x/emissions/keeper/msg_server_withdraw_emissions.go Show resolved Hide resolved
x/emissions/keeper/msg_server_withdraw_emissions.go Outdated Show resolved Hide resolved
@zeta-chain zeta-chain deleted a comment from akimov99900 Mar 4, 2024
@kingpinXD kingpinXD requested a review from lumtis March 5, 2024 07:10
lumtis
lumtis approved these changes Mar 5, 2024
View reviewed changes
x/emissions/types/keys.go Outdated Show resolved Hide resolved
skosito
skosito approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just couple of nit picky and typos comments, feel free to disregard if they don't make sense

docs/spec/emissions/messages.md Outdated Show resolved Hide resolved
x/emissions/client/cli/tx_withdraw_emssions.go Outdated Show resolved Hide resolved
x/emissions/keeper/msg_server_withdraw_emissions_test.go Show resolved Hide resolved
x/emissions/keeper/msg_server_withdraw_emissions_test.go Outdated Show resolved Hide resolved
x/emissions/keeper/withdrawable_emissions.go Outdated Show resolved Hide resolved
x/emissions/types/errors.go Show resolved Hide resolved
@kingpinXD kingpinXD merged commit 589e228 into develop Mar 5, 2024
21 checks passed
@kingpinXD kingpinXD deleted the withdraw-emissions branch March 5, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@skosito skosito skosito approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees
No one assigned
Labels
breaking:cli breaking:proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emissions : enable withdraw
3 participants
@kingpinXD @lumtis @skosito